[CASSANDRA-17738] Validate that JMX updates any new 4.1 properties (non-duration, non-data rate, non-data storage) in Config class and not local copies which can lead to inconsistencies between JMX and Settings Virtual Table after startup

• Type: Task
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.1-beta1, 4.1
• Component/s: Local/Config
• Change Category: Operability
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/1c70149ef512212d9cf8f57cb703fce92bf3dafa

Test and Documentation Plan

4.1 CI

trunk CI

• Assignee: Ekaterina Dimitrova
• Reporter: Ekaterina Dimitrova

Authors

Ekaterina Dimitrova

Reviewers

Brandon Williams

• Created: 06/Jul/22 15:27
• Updated: 05/Oct/22 22:22
• Resolved: 25/Jul/22 14:25

Description

Check that any properties which are added in 4.1 (non-Duration, non-Data Storage, non-Data Rate) are always updated by JMX in Config class and not local copies.This will ensure update in Settings Virtual Table after startup and no inconsistencies between JMX and Settings Virtual Table

I branched the configCompatibilityTest in 4.1 in order to get the lists of properties in this commit - the commit won't get into the codebase, just pasting so people know how the lists were generated:

columns_per_table_warn_threshold, partition_keys_in_select_fail_threshold, group_by_enabled, cdc_block_writes, paxos_variant, max_top_tombstone_partition_count, data_disk_usage_percentage_fail_threshold, internode_timeout, compaction_tombstone_warning_threshold, enable_uuid_sstable_identifiers, user_timestamps_enabled, paxos_topology_repair_no_dc_checks, scripted_user_defined_functions_enabled, denylist_max_keys_per_table, auth_cache_warming_enabled, write_consistency_levels_disallowed, auth_write_consistency_level, denylist_range_reads_enabled, roles_cache_active_update, paxos_repair_parallelism, hint_window_persistent_enabled, paxos_contention_max_wait, table_properties_ignored, read_before_write_list_operations_enabled, in_select_cartesian_product_warn_threshold, paxos_topology_repair_strict_each_quorum, top_partitions_enabled, secondary_indexes_per_table_fail_threshold, auto_snapshot_ttl, read_consistency_levels_warned, secondary_indexes_enabled, internode_error_reporting_exclusions, paxos_contention_min_delta, default_keyspace_rf, write_consistency_levels_warned, use_deterministic_table_id, sasi_indexes_enabled, min_tracked_partition_tombstone_count, minimum_replication_factor_fail_threshold, table_properties_disallowed, memtable, keyspaces_warn_threshold, transient_replication_enabled, user_defined_functions_enabled, user_defined_functions_threads_enabled, native_transport_max_requests_per_second, in_select_cartesian_product_fail_threshold, denylist_max_keys_total, tables_fail_threshold, read_consistency_levels_disallowed, fields_per_udt_warn_threshold, paxos_on_linearizability_violations, page_size_warn_threshold, minimum_replication_factor_warn_threshold, denylist_writes_enabled, traverse_auth_from_root, denylist_consistency_level, table_properties_warned, materialized_views_enabled, fields_per_udt_fail_threshold, denylist_reads_enabled, permissions_cache_active_update, available_processors, secondary_indexes_per_table_warn_threshold, tables_warn_threshold, client_error_reporting_exclusions, items_per_collection_warn_threshold, page_size_fail_threshold, paxos_contention_wait_randomizer, partition_denylist_enabled, skip_paxos_repair_on_topology_change_keyspaces, credentials_cache_active_update, failure_detector, drop_compact_storage_enabled, uncompressed_tables_enabled, materialized_views_per_table_fail_threshold, keyspaces_fail_threshold, data_disk_usage_percentage_warn_threshold, repair_state_size, paxos_contention_min_wait, auth_read_consistency_level, items_per_collection_fail_threshold, paxos_state_purging, materialized_views_per_table_warn_threshold, allow_filtering_enabled, columns_per_table_fail_threshold, paxos_repair_enabled, startup_checks, compact_tables_enabled, drop_truncate_table_enabled, max_top_size_partition_count, native_transport_rate_limiting_enabled, use_statements_enabled, auto_hints_cleanup_enabled, skip_paxos_repair_on_topology_change, partition_keys_in_select_warn_threshold, read_thresholds_enabled

Issue Links

• is a child of: CASSANDRA-17734 Validate that JMX and the Settings Virtual Table are aligned
• is cloned by: CASSANDRA-17739 Validate that JMX updates any old pre-4.1 properties (which are not moved to the new Config classes; non-duration, non-data rate, non-data storage)