[CASSANDRA-17656] jvm-dtest upgrade tests run all supported pairs of upgrades between from/to but does not actually test all patches from/to

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: NA
• Component/s: Test/dtest/java
• Bug Category: Correctness - API / Semantic Implementation
• Severity: Critical
• Complexity: Low Hanging Fruit
• Discovered By: Code Inspection
• Platform: All
• Since Version: NA

Source Control Link

https://github.com/apache/cassandra/commit/b7cc21516cfc5f95a7df4d86badac8b4195552a4

Test and Documentation Plan

run tests

• Assignee: David Capwell
• Reporter: David Capwell

Authors

David Capwell

Reviewers

Jon Meredith, Michael Semb Wever

• Created: 23/May/22 21:22
• Updated: 17/Jun/22 07:35
• Resolved: 06/Jun/22 21:53

Description

The current upgrade from/to logic is based off a list filter on from/to pairs, and runs the test multiple times for each pair; this does not actually validate that the different paths upgrade cleanly.

Instead, we need to test each supported path; example 3.0 -> 4.2

3.0.28 -> [4.2]
3.0.28 -> [3.11.14, 4.2]
3.0.28 -> [4.1-alpha1, 4.2]
3.0.28 -> [4.0.5, 4.2]
3.0.28 -> [3.11.14, 4.1-alpha1, 4.2]
3.0.28 -> [3.11.14, 4.0.5, 4.2]
3.0.28 -> [4.0.5, 4.1-alpha1, 4.2]
3.0.28 -> [3.11.14, 4.0.5, 4.1-alpha1, 4.2]

Issue Links

• is related to: CASSANDRA-17636 Test Failure: org.apache.cassandra.distributed.upgrade.MixedModeFrom3ReplicationTest.testSimpleStrategy
• links to: CI: trunk
• links to: PR: trunk