[CASSANDRA-17620] Incremental repair leaks SomeRepairFailedException after switch away from flatMap

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.1-alpha1, 4.1
• Component/s: Consistency/Repair
• Bug Category: Correctness - Test Failure
• Severity: Critical
• Complexity: Low Hanging Fruit
• Discovered By: Unit Test
• Platform: All
• Since Version: NA

Source Control Link

https://github.com/apache/cassandra/commit/5f5d2e65864d229baa6a20c72bb8e9189f13d395

Test and Documentation Plan

updated tests

• Assignee: David Capwell
• Reporter: David Capwell

Authors

David Capwell

Reviewers

Benedict Elliott Smith

• Created: 10/May/22 16:25
• Updated: 22/Oct/22 11:33
• Resolved: 10/May/22 22:28

Description

This is an extension of CASSANDRA-17549.

Incremental repair used to do a flatMap where it returned a failed future of SomeRepairFailedException; this would not trigger our failure logging to log it due to the fact the executor didn’t know about it and RepairRunnable knew to ignore that error, a change was made to use map and throw the exception, and later that behavior was updated to trigger uncaughtException handling which leaks this exception.

To roll back to previous behavior, we should switch back to flatMap to avoid this logging

Issue Links

• relates to: CASSANDRA-17549 jvm-dtest unhandled exceptions failing the test no longer work
• links to: GH: 4.1