[CASSANDRA-17595] nodetool enablefullquerylog can NPE when directory has no files

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.1-alpha1, 4.1
• Component/s: Tool/fql
• Bug Category: Correctness - Transient Incorrect Response
• Severity: Critical
• Complexity: Low Hanging Fruit
• Discovered By: Unit Test
• Platform: All
• Since Version: NA

Source Control Link

https://github.com/apache/cassandra/commit/559b17f71d3207158d34b1dd2414a531e362af20

Test and Documentation Plan

existing tests

• Assignee: David Capwell
• Reporter: David Capwell

Authors

David Capwell

Reviewers

Jon Meredith

• Created: 03/May/22 20:38
• Updated: 01/Oct/22 17:27
• Resolved: 04/May/22 16:36

Description

fqltool_test.py::TestFQLTool::test_unclean_enable found an issue with org.apache.cassandra.utils.binlog.BinLog#deleteRecursively, it assumes listing files returns empty list rather than null and throws a NPE

E           -- StackTrace --
E           java.lang.NullPointerException
E           	at org.apache.cassandra.utils.binlog.BinLog.deleteRecursively(BinLog.java:490)
E           	at org.apache.cassandra.utils.binlog.BinLog.cleanDirectory(BinLog.java:477)
E           	at org.apache.cassandra.utils.binlog.BinLog$Builder.build(BinLog.java:436)
E           	at org.apache.cassandra.fql.FullQueryLogger.enable(FullQueryLogger.java:106)
E           	at org.apache.cassandra.service.StorageService.enableFullQueryLogger(StorageService.java:6495)
E           	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
E           	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
E           	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
E           	at java.lang.reflect.Method.invoke(Method.java:498)
E           	at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:72)
E           	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
E           	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
E           	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
E           	at java.lang.reflect.Method.invoke(Method.java:498)
E           	at sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:276)
E           	at com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:112)
E           	at com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:46)
E           	at com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
E           	at com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:138)
E           	at com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:252)
E           	at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:819)
E           	at com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:801)
E           	at javax.management.remote.rmi.RMIConnectionImpl.doOperation(RMIConnectionImpl.java:1468)
E           	at javax.management.remote.rmi.RMIConnectionImpl.access$300(RMIConnectionImpl.java:76)
E           	at javax.management.remote.rmi.RMIConnectionImpl$PrivilegedOperation.run(RMIConnectionImpl.java:1309)
E           	at javax.management.remote.rmi.RMIConnectionImpl.doPrivilegedOperation(RMIConnectionImpl.java:1401)
E           	at javax.management.remote.rmi.RMIConnectionImpl.invoke(RMIConnectionImpl.java:829)

Issue Links

• links to: CI: trunk
• links to: GH: 4.1
• links to: PR: trunk