[CASSANDRA-17593] StorageService read threshold get methods throw NullPointerException due to not handling null configs

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.1-alpha1, 4.1
• Component/s: Observability/JMX
• Bug Category: Correctness - Transient Incorrect Response
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: User Report
• Platform: All
• Since Version: NA

Source Control Link

https://github.com/apache/cassandra/commit/7c4c30dc60f58312a5db5f02d2cfa222808d759d

Test and Documentation Plan

added tests

• Assignee: David Capwell
• Reporter: David Capwell

Authors

David Capwell

Reviewers

Berenguer Blasi

• Created: 02/May/22 17:26
• Updated: 17/Jun/22 07:40
• Resolved: 10/May/22 19:45

Description

org.apache.cassandra.service.StorageService#getCoordinatorLargeReadWarnThreshold and other similar get methods touch the following null configs

public volatile DataStorageSpec coordinator_read_size_warn_threshold = null;
public volatile DataStorageSpec coordinator_read_size_fail_threshold = null;
public volatile DataStorageSpec local_read_size_warn_threshold = null;
public volatile DataStorageSpec local_read_size_fail_threshold = null;
public volatile DataStorageSpec row_index_read_size_warn_threshold = null;
public volatile DataStorageSpec row_index_read_size_fail_threshold = null

Null is a valid state for these configs, so null must be handled in the get methods; they currently are not and throw NullPointerException when accessed via JMX

Issue Links

• links to: CI: trunk
• links to: PR: trunk