[CASSANDRA-17507] IllegalArgumentException in query code path during 3.11.12 => 4.0.3 rolling upgrade

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0.8, 4.1.1, 5.0-alpha1, 5.0
• Component/s: Consistency/Coordination
• Bug Category: Correctness - Transient Incorrect Response
• Severity: Normal
• Complexity: Normal
• Discovered By: User Report
• Platform: All
• Since Version: 4.0.0

Source Control Link

https://github.com/apache/cassandra/commit/9a0af4112e87f5b97056aa39e63c5ab461b60237

Test and Documentation Plan

New JVM upgrade dtests are included.

• Assignee: Andres de la Peña
• Reporter: Thomas Steinmaurer

Authors

Andres de la Peña

Reviewers

Berenguer Blasi, Piotr Kolaczkowski

• Created: 31/Mar/22 12:27
• Updated: 12/Sep/23 13:02
• Resolved: 23/Jan/23 11:50

Description

In a 6 node 3.11.12 test cluster - freshly set up, thus no legacy SSTables etc. - with ~ 1TB SSTables on disk per node, I have been running a rolling upgrade to 4.0.3. On upgraded 4.0.3 nodes I then have seen the following exception regularly, which disappeared once all 6 nodes have been on 4.0.3. Is this known? Can this be ignored? As said, just a test drive, but not sure if we want to have that in production, especially with a larger number of nodes, where it could take some time, until all are upgraded. Thanks!

ERROR [Native-Transport-Requests-8] 2022-03-30 11:30:24,057 ErrorMessage.java:457 - Unexpected exception during request
java.lang.IllegalArgumentException: newLimit > capacity: (290 > 15)
        at java.base/java.nio.Buffer.createLimitException(Buffer.java:372)
        at java.base/java.nio.Buffer.limit(Buffer.java:346)
        at java.base/java.nio.ByteBuffer.limit(ByteBuffer.java:1107)
        at java.base/java.nio.ByteBuffer.limit(ByteBuffer.java:262)
        at org.apache.cassandra.db.marshal.ByteBufferAccessor.slice(ByteBufferAccessor.java:107)
        at org.apache.cassandra.db.marshal.ByteBufferAccessor.slice(ByteBufferAccessor.java:39)
        at org.apache.cassandra.db.marshal.ValueAccessor.sliceWithShortLength(ValueAccessor.java:225)
        at org.apache.cassandra.db.marshal.CompositeType.splitName(CompositeType.java:222)
        at org.apache.cassandra.service.pager.PagingState$RowMark.decodeClustering(PagingState.java:434)
        at org.apache.cassandra.service.pager.PagingState$RowMark.clustering(PagingState.java:388)
        at org.apache.cassandra.service.pager.SinglePartitionPager.nextPageReadQuery(SinglePartitionPager.java:88)
        at org.apache.cassandra.service.pager.SinglePartitionPager.nextPageReadQuery(SinglePartitionPager.java:32)
        at org.apache.cassandra.service.pager.AbstractQueryPager.fetchPage(AbstractQueryPager.java:69)
        at org.apache.cassandra.service.pager.SinglePartitionPager.fetchPage(SinglePartitionPager.java:32)
        at org.apache.cassandra.cql3.statements.SelectStatement$Pager$NormalPager.fetchPage(SelectStatement.java:352)
        at org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:400)
        at org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:250)
        at org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:88)
        at org.apache.cassandra.cql3.QueryProcessor.processStatement(QueryProcessor.java:244)
        at org.apache.cassandra.cql3.QueryProcessor.processPrepared(QueryProcessor.java:723)
        at org.apache.cassandra.cql3.QueryProcessor.processPrepared(QueryProcessor.java:701)
        at org.apache.cassandra.transport.messages.ExecuteMessage.execute(ExecuteMessage.java:159)
        at org.apache.cassandra.transport.Message$Request.execute(Message.java:242)
        at org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:86)
        at org.apache.cassandra.transport.Dispatcher.processRequest(Dispatcher.java:106)
        at org.apache.cassandra.transport.Dispatcher.lambda$dispatch$0(Dispatcher.java:70)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
        at org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:165)
        at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:119)
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        at java.base/java.lang.Thread.run(Thread.java:829)

Issue Links

• is related to: CASSANDRA-16217 Minimal 4.0 COMPACT STORAGE backport