[CASSANDRA-17397] cleanup cqlshlib unit test failures and warnings

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.1-alpha1, 4.1
• Component/s: CQL/Interpreter
• Bug Category: Correctness - Test Failure
• Severity: Normal
• Complexity: Normal
• Discovered By: User Report
• Platform: All
• Since Version: NA

Source Control Link

https://github.com/apache/cassandra/commit/c408931aa262353845c926f367ad06d27d9f164e

Test and Documentation Plan

run CI

• Assignee: Brad Schoening
• Reporter: Brad Schoening

Authors

Brad Schoening

Reviewers

Brandon Williams, Stefan Miklosovic

• Created: 19/Feb/22 02:12
• Updated: 27/May/22 19:25
• Resolved: 09/Mar/22 16:16

Description

The cqlshlib unit tests have some regular failures and warnings.

1. test_copyutil.py fails with too many open files when ulimit is 256
2. cassconnect.py:39: DeprecationWarning: Legacy execution parameters
3. sslhandling.py:42: DeprecationWarning: The SafeConfigParser class has been renamed to ConfigParser 
4. remove unused reference to nosetests.xml in Jenkinsfile

 

The cqlshlib test test_copyutil.py fails on MacOS with 

E           OSError: [Errno 24] Too many open files

This happens because the test does not close the file descriptors after use.  The default ulimit on MacOS is small, 256:

     % ulimit -n

     256

The simple fix is to close the pipe after use.  Increasing ulimit nofiles works also, but shouldn't be necessary.

Issue Links

• links to: Github PR