[CASSANDRA-17335] Fix race condition bug during local session repair

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0.4, 4.1-alpha1, 4.1
• Component/s: Test/dtest/java
• Bug Category: Correctness - Test Failure
• Severity: Normal
• Complexity: Normal
• Discovered By: User Report
• Platform: All
• Since Version: 4.0.0

Source Control Link

https://github.com/apache/cassandra/commit/fd5e2ad74eff61e189c2abe87797c2690a45220c

Test and Documentation Plan

https://github.com/apache/cassandra/pull/1452/files

• Assignee: Bernardo Botella Corbi
• Reporter: Andres de la Peña

Authors

Bernardo Botella Corbi

Reviewers

Berenguer Blasi, Yifan Cai

• Created: 02/Feb/22 13:05
• Updated: 27/May/22 19:25
• Resolved: 04/Mar/22 18:47

Description

The in-JVM dtest RepairErrorsTest#testNoSuchRepairSessionAnticompaction seems to be flaky, as it's shown by this repeated run on trunk, which hits 18 failures in 500 iterations. The config for CircleCI was generated with:

.circleci/generate.sh -m \
  -e REPEATED_UTEST_TARGET=test-jvm-dtest-some \
  -e REPEATED_UTEST_COUNT=500 \
  -e REPEATED_UTEST_CLASS=org.apache.cassandra.distributed.test.RepairErrorsTest

This was discovered while testing CASSANDRA-16878, on this CI run.

The error consists on a failed assertion when grepping the logs in search of an error message.

Issue Links

• Discovered while testing: CASSANDRA-16878 Race in commit log replay can cause rejected mutations