[CASSANDRA-17209] Avoid unecessary array allocations and initializations in RequestValidations - ASF JIRA

Agile Board

Attach files

Attach Screenshot

Bulk Copy Attachments

Bulk Move Attachments

Voters

Watch issue

Watchers

Create sub-task

Convert to sub-task

Move

Link

Clone

Labels

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Resolved
Priority: Normal
Resolution: Fixed
Fix Version/s: 4.1-alpha1, 4.1
Component/s: CQL/Interpreter
Labels:
None

Change Category:
Performance
Complexity:
Low Hanging Fruit
Platform:

All
Impacts:

None
Source Control Link:

https://github.com/apache/cassandra/commit/11952fae774d51d4e268dae506803fef874c8c50
Test and Documentation Plan:

Hide

No need for new tests

Show
No need for new tests

Description

RequestValidations methods used extensively varargs. As the array creation is necessary only when the check fail we endup creating most of the time unecessary array. This can easily be avoided by overloading the different methods with a number of message argument from zero to three.

Attachments

Activity

Comment

This comment will be Viewable by All Users Viewable by All Users

Cancel

People

Assignee:: Benjamin Lerer Assign to me

Reporter:: Benjamin Lerer

Authors:: Benjamin Lerer

Reviewers:: Caleb Rackliffe

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 15/Dec/21 11:29

Updated:: 27/May/22 19:25

Resolved:: 20/Dec/21 13:08

Agile

View on Board

Avoid unecessary array allocations and initializations in RequestValidations

Details

Description

Attachments

Attachments

Activity

People

Dates

Agile

Slack

Issue deployment