[CASSANDRA-17181] SchemaCQLHelperTest methods can be simplified - ASF JIRA

Agile Board

Attach files

Attach Screenshot

Bulk Copy Attachments

Bulk Move Attachments

Voters

Watch issue

Watchers

Create sub-task

Convert to sub-task

Move

Link

Clone

Labels

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Resolved
Priority: Normal
Resolution: Fixed
Fix Version/s: 4.0.2, 4.1-alpha1, 4.1
Component/s: Local/Snapshots
Labels:
- AdventCalendar2021
- lhf

Complexity:
Low Hanging Fruit
Platform:

All
Impacts:

None
Source Control Link:

https://github.com/apache/cassandra/commit/75482d0a8ccd0b0d370aeb7ee60c72cd47a191b0
Test and Documentation Plan:

Hide

The patch update existing tests

Show
The patch update existing tests

Description

SchemaCQLHelperTest is used during a snapshot to generate the schema.cql file. The methods accept the following paramaters: includeDroppedColumns, internals and ifNotExists.
Those parameters are in practice always set to true by the calling code and therefore can be removed.

Attachments

CASSANDRA-17181-4.0.patch
13/Dec/21 13:11
16 kB
Bartlomiej

Activity

Comment

This comment will be Viewable by All Users Viewable by All Users

Cancel

People

Assignee:: Bartlomiej Assign to me

Reporter:: Benjamin Lerer

Authors:: Bartlomiej

Reviewers:: Benjamin Lerer, Ekaterina Dimitrova

Votes:: 1 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 02/Dec/21 17:37

Updated:: 27/May/22 19:25

Resolved:: 15/Dec/21 17:51

Agile

View on Board

SchemaCQLHelperTest methods can be simplified

Details

Description

Attachments

Attachments

Activity

People

Dates

Agile

Slack

Issue deployment