[CASSANDRA-17174] Harden resource management on SSTable components to prevent further leaks

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.1-alpha1, 4.1
• Component/s: Local/SSTable
• Change Category: Operability
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=commit;h=8e28dc0ebac3d80db43acfe76cfb45c0cb17a5c8

Test and Documentation Plan

No new testing or documentation called for.

• Assignee: Josh McKenzie
• Reporter: Josh McKenzie

Authors

Josh McKenzie

Reviewers

Caleb Rackliffe

• Created: 29/Nov/21 16:22
• Updated: 27/May/22 19:25
• Resolved: 01/Dec/21 17:38

Description

We've seen resource leaks pop up w/histogram overflows repeatedly; the code in BigTableWriter.openEarly() and BigTableWriter.openFinal() doesn't appropriately catch and handle any exceptions during creation before things are registered with a LifecycleTransaction so any errors there will leak.

We should clean that up.