[CASSANDRA-17161] Remove commitlog_sync_batch_window_in_ms

• Type: Task
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0, 5.1
• Component/s: Build
• Epic Link: cassandra-post-4x-cleanup
• Change Category: Code Clarity
• Complexity: Normal
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/7b89b6018dc6aef82404e8422043ea3769cbbefd

Test and Documentation Plan

CI

• Assignee: Stefan Miklosovic
• Reporter: Ekaterina Dimitrova

Authors

Stefan Miklosovic

Reviewers

Brandon Williams

• Created: 17/Nov/21 20:17
• Updated: 12/Sep/23 13:02
• Resolved: 09/Aug/23 20:10

Description

commitlog_sync_batch_window_in_ms is deprecated in 4.0 and has to be removed in 5.0

This will require also some work around the in-jvm upgrade tests.

Currently they do not work if we remove a parameter in a later version.

Side note: They also don't work if we change the type of the parameter in Config class in a newer Cassandra version. If you plan to set it in the tests themselves, it won't work. If you change the type but your don't set the parameter, no issue so there might be some workaround solution instead of working on the dtest framework itself.... TBD

Issue Links

• is blocked by: CASSANDRA-17973 Change trunk 4.2 to 5.0
• links to: GitHub Pull Request #2533