[CASSANDRA-17069] Refactor normal/preview/IR repair to standardize repair cleanup and error handling of failed RepairJobs

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.1-alpha1, 4.1
• Component/s: Consistency/Repair
• Change Category: Quality Assurance
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/b84ec51b4c73d7b9b58ea8a1708ae2f330972970

Test and Documentation Plan

added tests and rely on existing ones

• Assignee: David Capwell
• Reporter: David Capwell

Authors

David Capwell

Reviewers

Marcus Eriksson

• Created: 27/Oct/21 15:05
• Updated: 27/May/22 19:25
• Resolved: 13/Nov/21 01:03

Description

Right now we have 3 different implementations of repair: normal, preview, and incremental (IR); all 3 handle RepairJob failures differently and offer different state cleanup. To make sure that we consistently handle errors the same way and cleanup, we should move these responsibilities outside of the repair task itself and move these into common APIs and move some logic into the repair coordination its self.

This work relates with CASSANDRA-15399 as special handling each task makes the work more complex.

Issue Links

• relates to: CASSANDRA-16909 ☂ Medium Term Repair Improvements
• links to: Circle CI: trunk
• links to: GH PR: trunk