[CASSANDRA-16992] repair prepare message would produce a wrong error message if network timeout happened rather than reply wait timeout

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.1-alpha1, 4.1
• Component/s: Consistency/Repair, Test/dtest/java
• Bug Category: Correctness - Test Failure
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: DTest
• Platform: All
• Since Version: 3.0.0

Source Control Link

https://github.com/apache/cassandra/commit/bebe20d2a7b4939158169990d7a9a856e086d532

Test and Documentation Plan

repeat jobs

• Assignee: David Capwell
• Reporter: Josh McKenzie

Reviewers

Berenguer Blasi

• Created: 24/Sep/21 14:42
• Updated: 27/May/22 19:25
• Resolved: 19/Nov/21 22:33

Description

Showed up on CASSANDRA-12988 test runs; can't reproduce locally.

 

junit.framework.AssertionFailedError: nodetool command [repair, distributed_test_keyspace, preparerpctimeout_full_parallel_false, --full] Error message 'Got negative replies from endpoints [/127.0.0.2:7012]' does not contain any of [Did not get replies from all endpoints.]
stdout:
[2021-09-22 17:37:02,187] After waiting for poll interval of 1 seconds queried for parent session status and discovered repair failed.
[2021-09-22 17:37:02,187] Got negative replies from endpoints [/127.0.0.2:7012]
[2021-09-22 17:37:02,187] Repair command #4 finished with error

stderr:
error: Got negative replies from endpoints [/127.0.0.2:7012]
– StackTrace –
java.io.IOException: Got negative replies from endpoints [/127.0.0.2:7012]
at org.apache.cassandra.tools.RepairRunner.queryForCompletedRepair(RepairRunner.java:167)
at org.apache.cassandra.tools.RepairRunner.run(RepairRunner.java:72)
at org.apache.cassandra.tools.NodeProbe.repairAsync(NodeProbe.java:461)
at org.apache.cassandra.tools.nodetool.Repair.execute(Repair.java:171)
at org.apache.cassandra.tools.NodeTool$NodeToolCmd.runInternal(NodeTool.java:363)
at org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:348)
at org.apache.cassandra.tools.NodeTool.execute(NodeTool.java:251)
at org.apache.cassandra.distributed.impl.Instance$DTestNodeTool.execute(Instance.java:895)
at org.apache.cassandra.distributed.impl.Instance.lambda$nodetoolResult$39(Instance.java:805)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.base/java.lang.Thread.run(Thread.java:834)

Issue Links

• links to: CI: trunk
• links to: GH PR: trunk