[CASSANDRA-16925] Task Execution

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.1-alpha1, 4.1
• Component/s: Legacy/Core
• Change Category: Quality Assurance
• Complexity: Normal
• Platform: All

Source Control Link

e215d2a5b25991b47cec66cc1a970d835b89005b

Test and Documentation Plan

new and existing utests & dtests

• Assignee: Benedict Elliott Smith
• Reporter: Benedict Elliott Smith

Authors

Benedict Elliott Smith

Reviewers

Sam Tunnicliffe

• Created: 08/Sep/21 17:49
• Updated: 28/Feb/23 17:16
• Resolved: 07/Oct/21 11:29

Description

To support CEP-10 it is necessary to support alternative executor implementations that may be externally controlled. This ticket introduces an ExecutorFactory, and all executor creation is migrated to this facility. The codebase’s use of executors is inconsistent, and relatedly there are divergent Future APIs in use, with Netty, Guava and Java APIs in use in various places. To improve consistency we introduce our own Future API that implements all of the above, as well as providing other additional ergonomic improvements. We introduce a new ExecutorPlus API that extends Executor to supply this extended Future API. All executors and futures are ported to these new APIs to improve coherency in the codebase, and to support consistently mocking these implementations.

DebuggableThreadPoolExecutor and its hierarchy is replaced with ThreadPoolExecutorBase, ThreadPoolExecutorPlus and extending classes with consistent names, implementations and configurability.

Additionally the ExecutorFactory takes over the allocation of new threads, and provides a new InfiniteLoopExecutorfacility for common paradigms.

Issue Links

• causes: CASSANDRA-17928 Test Failure: org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
• is a child of: CASSANDRA-16922 CEP-10: Major Prerequisites (Phase 1)
• relates to: CASSANDRA-17125 Remove use of deprecated Futures in tests