[CASSANDRA-16924] Blocking Concurrency Primitives

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.1-alpha1, 4.1
• Component/s: Legacy/Core
• Change Category: Quality Assurance
• Complexity: Normal
• Platform: All

Source Control Link

5c3a05a5787f7ab0b46e3a6401d64f376f6c9d9f

Test and Documentation Plan

new and existing utests/dtests

• Assignee: Benedict Elliott Smith
• Reporter: Benedict Elliott Smith

Authors

Benedict Elliott Smith

Reviewers

Aleksei Zotov, Sam Tunnicliffe

• Created: 08/Sep/21 17:48
• Updated: 03/Nov/22 10:39
• Resolved: 07/Oct/21 11:28

Description

To support CEP-10 it is necessary to support alternative implementations of the blocking concurrency primitives we use on the project. At the same time, the project is very inconsistent in its usage of these APIs, so this work includes a number of improvements to the coherency of the codebase.

This ticket introduces new abstractions and standardises old ones, migrating all blocking concurrency operations besides Futures returned by Executors to these new APIs. This includes a migration of SimpleCondition to a new Conditioninterface, new CountDownLatch and Semaphore interfaces, and new static factory methods for creating these objects (as well as WaitQueue) that can be intercepted by byte weaving. Additionally the internal Netty Future implementation is improved to support more general use (though this is only fully realised in a later ticket), OpOrder is improved to more easily support mocking WaitQueue.

Finally we standardise the propagation of InterruptedExecption, with the new UncheckedInterruptedException, so that simulations may be terminated cleanly.

Issue Links

• causes: CASSANDRA-17928 Test Failure: org.apache.cassandra.db.commitlog.CommitLogInitWithExceptionTest.testCommitLogInitWithException-compression
• is a child of: CASSANDRA-16922 CEP-10: Major Prerequisites (Phase 1)