[CASSANDRA-16904] Check if size of object being added to RowCache and KeyCache is bigger than cache capacity

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Component/s: Local/Caching
• Platform: All
• Assignee: Josh McKenzie
• Reporter: Josh McKenzie

Authors

Josh McKenzie

• Created: 31/Aug/21 16:41
• Updated: 03/Sep/21 13:47
• Resolved: 03/Sep/21 13:47

Description

We don't check if the size of an object being added to the RowCache/KeyCache itself exceeds the max configured size of the cache.

For instance, if a RowCache object is ~5GB due to IndexInfo objects, but the cache is configured to have a max capacity of 100MB, we will still add the 5GB object into the cache and then need to wait for the eviction thread in the cache to come around, realize we're over capacity, and remove the object from the cache.

We could check the size of the object with jamm and ensure it's smaller than the max size of the cache. If it exceeds the size of the cache don't cache it at all.

Issue Links

• is superceded by: CASSANDRA-11206 Support large partitions on the 3.0 sstable format