[CASSANDRA-16892] Fix flakiness in upgrade_tests/thrift_upgrade_test.py in dtests

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: NA
• Component/s: Test/dtest/python
• Bug Category: Code
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: DTest
• Platform: All
• Since Version: NA

Source Control Link

https://github.com/apache/cassandra-dtest/commit/2ed526a43d3a37b00ada500a0354955fecf1e61c

Test and Documentation Plan

https://github.com/apache/cassandra-dtest/pull/156

• Assignee: Stefan Miklosovic
• Reporter: Stefan Miklosovic

Authors

Stefan Miklosovic

Reviewers

Benjamin Lerer

• Created: 27/Aug/21 10:59
• Updated: 01/Jun/23 14:36
• Resolved: 06/Sep/21 07:12

Description

I noticed that tests for dtest in upgrade_tests/thrift_upgrade_test.py are flaky.

The reason this flakiness happens is that we are stopping and starting a node too fast without waiting for its full initialisation and then next attempt to connect to rpc port fails and whole test fails.

The fix is rather easy, we just need to wait until it is full started.