Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-16629

Refactor tests for NodeTool commands

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Low
    • Resolution: Fixed
    • Fix Version/s: 4.1
    • Component/s: Test/unit
    • Labels:
      None
    • Change Category:
      Code Clarity
    • Complexity:
      Low Hanging Fruit
    • Platform:
      All
    • Impacts:
      None
    • Test and Documentation Plan:
      Hide

      These changes are purely cosmetic and affect unit tests only. Hence, no test and documentation plans are required.

      Show
      These changes are purely cosmetic and affect unit tests only. Hence, no test and documentation plans are required.

      Description

      Overview

      As a part of CASSANDRA-16404, I've been working on NodeTool commands for invalidation of the auth caches. While working on that, I've mentioned that the existing NodeTool unit tests are written in a different manner and reside in wrong packages. I've made the following changes to them:

      1. moved them to the proper packages (that match original command class)
      2. unified naming, formatting, imports
      3. migrated from org.assertj to hamcrest for assertions (though it is not smth really required)
      4. made a general cleanup

      PR: https://github.com/apache/cassandra/pull/982

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                azotcsit Aleksei Zotov
                Reporter:
                azotcsit Aleksei Zotov
                Authors:
                Aleksei Zotov
                Reviewers:
                Benjamin Lerer
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m