[CASSANDRA-16629] Refactor tests for NodeTool commands

• Type: Task
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 4.1-alpha1, 4.1
• Component/s: Test/unit
• Change Category: Code Clarity
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/5fc811210b70889084b2be5a6a3577963fd5f3c4

Test and Documentation Plan

These changes are purely cosmetic and affect unit tests only. Hence, no test and documentation plans are required.

• Assignee: Aleksei Zotov
• Reporter: Aleksei Zotov

Authors

Aleksei Zotov

Reviewers

Benjamin Lerer

• Created: 24/Apr/21 10:22
• Updated: 27/May/22 19:25
• Resolved: 06/May/21 11:59

Description

Overview

As a part of CASSANDRA-16404, I've been working on NodeTool commands for invalidation of the auth caches. While working on that, I've mentioned that the existing NodeTool unit tests are written in a different manner and reside in wrong packages. I've made the following changes to them:

1. moved them to the proper packages (that match original command class)
2. unified naming, formatting, imports
3. migrated from org.assertj to hamcrest for assertions (though it is not smth really required)
4. made a general cleanup

PR: https://github.com/apache/cassandra/pull/982

Issue Links

• relates to: CASSANDRA-16135 Separate in-JVM test into smaller packages