[CASSANDRA-1661] Use of ByteBuffer limit() must account for arrayOffset()

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 0.7 beta 3
• Severity: Normal
• Assignee: T Jake Luciani
• Reporter: T Jake Luciani

Authors

T Jake Luciani

Reviewers

Stu Hood

• Created: 25/Oct/10 15:06
• Updated: 16/Apr/19 09:33
• Resolved: 26/Oct/10 03:14

Description

There are a few places in the code where it loops across a byte buffers backing array wrong:

for (int i=bytes.position()bytes.arrayOffset(); i<bytes.limit(); i+)

This is incorrect as the limit() does not account for arrayOffset()

for (int i=bytes.position()bytes.arrayOffset(); i<bytes.limit()+bytes.arrayOffset(); i+)

is the correct code.

There is also a few places where the unit tests would fail if we used non wrapped byte arrays.