[CASSANDRA-16613] ProtocolVersion.V4 is still used in places in the code

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-rc2, 4.0, 4.1-alpha1, 4.1
• Bug Category: Correctness
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: User Report
• Platform: All
• Since Version: 4.0-beta4

Source Control Link

https://github.com/apache/cassandra/commit/62e1d74701bcb59437aeb1c778ba7a81aac84741

Test and Documentation Plan

https://issues.apache.org/jira/browse/CASSANDRA-16613?focusedCommentId=17335087&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17335087

• Assignee: Ekaterina Dimitrova
• Reporter: Ekaterina Dimitrova

Authors

Ekaterina Dimitrova

Reviewers

Sam Tunnicliffe

• Created: 18/Apr/21 00:16
• Updated: 27/May/22 19:25
• Resolved: 08/May/21 14:21

Description

While working on CASSANDRA-16567, adelapena observed that ProtocolVersion.V4 is used in ViewTest.

I decided to do a quick grep and observed a list of places where we still refer to V4 and it seems at least in many of the tests that was left not intentionally.

This ticket is to verify the usage of ProtocolVersion.V4 in the codebase and bump it to V5 or default version, similar to what was done in CASSANDRA-16567, wherever there is a need.

Issue Links

• is related to: CASSANDRA-15299 CASSANDRA-13304 follow-up: improve checksumming and compression in protocol v5-beta
• is related to: CASSANDRA-14973 Bring protocol v5 out of beta, introduce v6 before 4.0 release is cut
• relates to: CASSANDRA-16642 Create release branch cassandra-4.0