Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-16588

NPE getting host_id in Gossiper.isSafeForStartup

Agile BoardAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      As seen here: https://ci-cassandra.apache.org/job/Cassandra-devbranch/604/testReport/junit/org.apache.cassandra.distributed.upgrade/MixedModeGossipTest/testStatusFieldShouldExistInOldVersionNodesEdgeCase/

      java.lang.NullPointerException
      	at org.apache.cassandra.gms.Gossiper.isSafeForStartup(Gossiper.java:952)
      	at org.apache.cassandra.service.StorageService.checkForEndpointCollision(StorageService.java:657)
      	at org.apache.cassandra.service.StorageService.prepareToJoin(StorageService.java:933)
      	at org.apache.cassandra.service.StorageService.initServer(StorageService.java:784)
      	at org.apache.cassandra.service.StorageService.initServer(StorageService.java:729)
      	at org.apache.cassandra.distributed.impl.Instance.lambda$startup$10(Instance.java:541)
      	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
      	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
      	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
      	at java.lang.Thread.run(Thread.java:748)
      

      I believe what is happening is a GossipDigestAck has been queued to ack the shutdown state from the node on the seed, but isn't actually sent until the node has restarted and gone into shadow. Since the ack contains the node's IP, it assumes a host_id will be there but since this is not an actual shadow response, it is not.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            brandon.williams Brandon Williams Assign to me
            brandon.williams Brandon Williams
            Brandon Williams
            Sam Tunnicliffe
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment