[CASSANDRA-16483] ColumnFilter::toString doesn't return a valid CQL fragment

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.25, 3.11.11, 4.0-rc1, 4.0
• Component/s: Observability/Logging
• Bug Category: Code - Bug - Unclear Impact
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: Unit Test
• Platform: All
• Since Version: 3.0.0

Source Control Link

https://github.com/apache/cassandra/commit/9c7b69e4229b6817b248bcf5270a783eed1f9930 https://github.com/apache/cassandra-dtest/commit/7d10bdd19765bc337ee7bbe516c3a1e76391f5c0

Test and Documentation Plan

The proposed PRs include the new toCQLString method in ColumnFilterTest. Also the dtests for the slow query logger are extended to include column selections.

• Assignee: Andres de la Peña
• Reporter: Sam Tunnicliffe

Authors

Andres de la Peña

Reviewers

Benjamin Lerer

• Created: 04/Mar/21 12:16
• Updated: 11/Mar/21 12:50
• Resolved: 10/Mar/21 17:46

Description

This was changed in CASSANDRA-16415 to include indications about queried vs fetched reagular & static columns. However, the result is used by AbstractReadQuery::toCQLString, which causes it to produce an illegal query string.

This breaks a couple of dtests because they're looking for CQL strings in logs, which are no longer found:

• upgrade_tests/paging_test.py::TestPagingWithDeletions::test_failure_threshold_deletions
• cql_test.py::TestCQLSlowQuery has a couple of failing tests, test_local_query/test_remote_query

We should also check audit and fql logs (and any other place where toCQLString is used.

Issue Links

• is caused by: CASSANDRA-16415 Digest mismatches during upgrade
• is related to: CASSANDRA-16510 Make ReadCommand::toCQLString return valid CQL
• links to: PR 3.0
• links to: PR 3.11
• links to: PR dtests
• links to: PR trunk