[CASSANDRA-16407] Add possibility to copy SSTables in SSTableImporter instead of moving them

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-rc1, 4.0
• Component/s: Local/SSTable
• Change Category: Operability
• Complexity: Normal
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/309b3033d44c5cdc18d6e3897661966853d39407

Test and Documentation Plan

ci run, new unit tests

• Assignee: Stefan Miklosovic
• Reporter: Stefan Miklosovic

Authors

Stefan Miklosovic

Reviewers

Marcus Eriksson, Michael Semb Wever

• Created: 26/Jan/21 21:06
• Updated: 22/Jun/21 23:29
• Resolved: 05/Mar/21 10:09

Description

SSTableImporter moves data from source to target. Modify the current code in such a way that source files / SSTables might be copied over, not moved. The reason behind this is that if I have a backup, I do not want to lose that backup after I import it. Backup should stay as it was, untouched. Callers might choose what behavior they require, either importing by moving or importing by copying.

Please keep in mind that SSTableImporter was firstly introduced in 4.0 trunk and this is seen as a bug basically, I was dedicing between a bug and improvement. I still believe that this should happen BEFORE 4.0 gets out.

https://github.com/apache/cassandra/pull/875/files

https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/376/