[CASSANDRA-16405] Handle both TimeoutError and NodeError when expecting node start failure

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 2.1.23, 3.0.24, 3.11.10, 4.0-rc1, 4.0
• Component/s: Test/dtest/python
• Change Category: Quality Assurance
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://github.com/apache/cassandra-dtest/commit/2a721e7b058025f42f8b86c8a2ecd851c2790f00 https://github.com/apache/cassandra-dtest/commit/ebb59dd7cf0c4fb4a9d9135cf6442e59c109de31 https://github.com/riptano/ccm/commit/89af9303b9edad55f02883170fc1e100065c

Test and Documentation Plan

I plan to run CircleCI tests or ask Mick to run some tests for me.

Acceptance criteria: no new regression.

• Assignee: Tomasz Lasica
• Reporter: Tomasz Lasica

Authors

Tomasz Lasica

Reviewers

Jacek Lewandowski, Michael Semb Wever

• Created: 25/Jan/21 10:01
• Updated: 29/Jan/21 13:19
• Resolved: 29/Jan/21 13:19

Description

Summary

Some tests are validating situation, when node (or cluster) does not start correctly.

They rely on `TimeoutError` to be raised, but technically it is also possible that `ccm` will raise `NodeError` without waiting for timeout to be met.

Why we need this change

We can improve `ccm` to fail fast in case node being started terminates. This would:

• make unexpected test failures faster to fail (not waiting 90 or 120s)
• shorten overall test duration, even if timeout is given

ccm work (in progress): https://github.com/riptano/ccm/pull/724

Proposed improvement

Handle both TimeoutError and NodeError as expected node failure.

PR

https://github.com/apache/cassandra-dtest/pull/120