[CASSANDRA-16398] Add access and datacenters to unreserved keywords

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-rc1, 4.0
• Component/s: CQL/Interpreter, CQL/Syntax
• Bug Category: Correctness - API / Semantic Implementation
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: User Report
• Platform: All
• Since Version: 4.0-alpha1

Source Control Link

https://github.com/apache/cassandra/commit/0373037a0db7e13548b0f302cad9414f00e58991

Test and Documentation Plan

unit test. ci

• Assignee: Yifan Cai
• Reporter: Yifan Cai

Authors

Yifan Cai

Reviewers

Benjamin Lerer

• Created: 22/Jan/21 01:27
• Updated: 16/Mar/22 15:21
• Resolved: 03/Feb/21 19:31

Description

The terms, "ACCESS TO ALL DATACENTERS" (for role control,) are introduced in CASSANDRA-13985. 
They are not marked as unreserved keywords. So in the non-role related DDL statements, for example, create table statement, the parser fails.
 
cqlsh> CREATE TABLE test.test_access ( foo text PRIMARY KEY, access text, bar text);
SyntaxException: line 1:54 mismatched input 'access' expecting ')' (... foo text PRIMARY KEY, [access]...)
 
cqlsh> CREATE TABLE test.test_datacenters ( foo text PRIMARY KEY, datacenters text, bar text);
SyntaxException: line 1:59 mismatched input 'datacenters' expecting ')' (... foo text PRIMARY KEY, [datacenters]...)
 
Since ACCESS and DATACENTERS are only applicable to the role defining statements. We should mark them as unreserved keywords in order to allow to use them in the DDL statement. 

Issue Links

• is related to: CASSANDRA-15537 4.0 quality testing: Local Read/Write Path: Upgrade and Diff Test