[CASSANDRA-16395] Increase node start timeout for selected bootstrap and replace node tests

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 2.2.20, 3.0.24, 3.11.10, 4.0-rc1, 4.0
• Component/s: Test/dtest/python
• Change Category: Quality Assurance
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://github.com/apache/cassandra-dtest/commit/e8c2b94b6f106e276800aa3de2628a73a70ac5e6

Test and Documentation Plan

I plan to run CircleCI tests or ask Mick to run some tests for me.

Acceptance criteria: no new regression.

• Assignee: Tomasz Lasica
• Reporter: Tomasz Lasica

Authors

Tomasz Lasica

Reviewers

Michael Semb Wever

• Created: 19/Jan/21 08:45
• Updated: 25/Jan/21 10:06
• Resolved: 21/Jan/21 12:53

Description

Summary

Node start timeouts should be explicitly extended to more than default 90s (boostrap with reset state, replace node tests) because the default 90s will start to work after ccm changes.

Why we need this change

There is a bug in https://github.com/riptano/ccm that node.start() timeout (or more precisely node.wait_for_binary_proto() timeout is in practice 600s. This is the time to wait for certain log message:

https://github.com/riptano/ccm/blob/484476494bda6d71f895826358722a7b1c47a3cf/ccmlib/node.py#L642

This bug will be fixed by: https://github.com/riptano/ccm/pull/725

Proposed improvement

Explicitly raise node start timeout to 120s or 180s (depending on the scenario) by using existing `Node` api to provide timeout as int (in seconds) instead of bool.

Note that this is available after https://github.com/riptano/ccm/pull/725 is merged but should not break test logic before it is merged.

PR

https://github.com/apache/cassandra-dtest/pull/113/files