Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-16361

DROP COMPACT STORAGE should invalidate prepared statements still using CompactTableMetadata

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Fix Version/s: 4.0-beta4, 4.0
    • Component/s: Legacy/CQL
    • Labels:
      None
    • Bug Category:
      Correctness - Transient Incorrect Response
    • Severity:
      Normal
    • Complexity:
      Normal
    • Discovered By:
      Unit Test
    • Platform:
      All
    • Impacts:
      None
    • Since Version:
    • Test and Documentation Plan:
      Hide

      a new test that verifies the contents of the prepared statement cache around the DROP COMPACT STORAGE logic

      Show
      a new test that verifies the contents of the prepared statement cache around the DROP COMPACT STORAGE logic

      Description

      When we drop compact storage from a table, existing prepared statements continue to refer to an instance of CompactTableMetadata, rather than being invalidated so they can be assigned a new TableMetadata instance. There are perhaps some brute force ways to fix this, like bouncing the node, but that obviously sub-optimal.

      One idea is to have TableMetadata#changeAffectsPreparedStatements() return true when we go from having to not having the DENSE flag. It should be pretty easy to validate a fix with a small addition to CompactTableTest.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                maedhroz Caleb Rackliffe
                Reporter:
                maedhroz Caleb Rackliffe
                Authors:
                Caleb Rackliffe
                Reviewers:
                Alex Petrov, Michael Semb Wever
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h
                  1h