[CASSANDRA-16353] Fix client push notifications in protocol v5

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-rc1, 4.0
• Component/s: Messaging/Client
• Labels: protocolv5
• Bug Category: Degradation - Other Exception
• Severity: Normal
• Complexity: Normal
• Discovered By: Unit Test
• Platform: All
• Impacts: Clients
• Since Version: 4.0-beta4

Source Control Link

https://github.com/apache/cassandra/commit/c9d22583d22d566807e76fa10c65af29104ae16c

Test and Documentation Plan

Add test coverage of client notifications for all supported protocol versions.

• Assignee: Sam Tunnicliffe
• Reporter: Sam Tunnicliffe

Authors

Sam Tunnicliffe

Reviewers

Benjamin Lerer

• Created: 15/Dec/20 18:00
• Updated: 19/Jan/21 14:37
• Resolved: 19/Jan/21 14:37

Description

The changes to native protocol v5 in CASSANDRA-15299 broke the delivery of push notifications from server to client. This wasn't caught earlier as there weren't any unit or dtests which would exercise client notifications in a beta protocol version. Working on CASSANDRA-14973 to bring v5 out of beta exposed the regression.