[CASSANDRA-16323] Circle CI python upgrade test build includes non-upgrade tests

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta4, 4.0
• Component/s: CI
• Bug Category: Correctness - API / Semantic Implementation
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: Code Inspection
• Platform: All
• Since Version: 4.0-alpha1

Source Control Link

https://github.com/apache/cassandra/commit/ab9fcd7d105d199efb1cb9db3f5702b5ba0461cd

Test and Documentation Plan

ci

• Assignee: David Capwell
• Reporter: David Capwell

Authors

David Capwell

Reviewers

Brandon Williams

• Created: 09/Dec/20 22:15
• Updated: 03/Jan/21 16:58
• Resolved: 10/Dec/20 21:51

Description

https://app.circleci.com/pipelines/github/dcapwell/cassandra/841/workflows/bcadf6e6-8d04-4010-8a47-99f7f9b5ac1d/jobs/4949/parallel-runs/23?filterBy=ALL

Jenkins uses the following for finding tests

export RUN_STATIC_UPGRADE_MATRIX=true
./run_dtests.py \
    --execute-upgrade-tests-only \
    --dtest-print-tests-only \
    --dtest-print-tests-output=${WORKSPACE}/test_list.txt \
    --cassandra-dir=$CASSANDRA_DIR

Where as circle ci uses

export RUN_STATIC_UPGRADE_MATRIX=true
./run_dtests.py \
    --execute-upgrade-tests \
    --dtest-print-tests-only \
    --dtest-print-tests-output=/tmp/all_dtest_tests_j8_upgradetests_without_vnodes_raw \
    --cassandra-dir=../cassandra

The difference here is that —execute-upgrade-tests-only will block non-upgrade tests, where —execute-upgrade-tests will include upgrade tests; for this reason non-upgrade tests are scheduled as part of the build.

Tests such as the following were found in the allow list:
transient_replication_test.py::TestTransientReplicationSpeculativeQueries::test_custom_speculate
ttl_test.py::TestTTL::test_collection_set_ttl
auth_test.py::TestAuth::test_alter_ks_auth

many more were found

Issue Links

• is a child of: CASSANDRA-15588 4.0 quality testing: Cluster Upgrade
• links to: Circle CI: trunk
• links to: GH Branch: trunk