[CASSANDRA-16305] Remove duplicate code used by CQLTester and SchemaLoader

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta4, 4.0
• Component/s: Test/unit
• Change Category: Quality Assurance
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/c7d098c7ac9f4a7f8db73b71061375bfbf70be30

Test and Documentation Plan

The refactoring did not break any tests.

• Assignee: Benjamin Lerer
• Reporter: Benjamin Lerer

Authors

Benjamin Lerer

Reviewers

Berenguer Blasi

• Created: 27/Nov/20 16:36
• Updated: 03/Jan/21 16:58
• Resolved: 02/Dec/20 09:57

Description

While digging into the cause behind CASSANDRA-16302, we discovered that there is some duplicate code in SchemaLoader and CQLTester. Over time that code has evolved slightly differently in both classes leading to some different behavior.

Having the same code being used by both class will ensure that if the code needs to be change the behavior will be correct same one for both classes.