[CASSANDRA-16284] Too defensive check when picking sstables for preview repair

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta5, 4.0
• Component/s: Consistency/Repair
• Bug Category: Degradation - Other Exception
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: Code Inspection
• Platform: All
• Since Version: 4.0-alpha1

Source Control Link

https://github.com/apache/cassandra/commit/0e059c42f298686d6a219b4bc0b7973652f4183d

Test and Documentation Plan

cci run, new jvm dtest

• Assignee: Marcus Eriksson
• Reporter: Marcus Eriksson

Authors

Marcus Eriksson

Reviewers

Adam Holmberg, Ekaterina Dimitrova

• Created: 18/Nov/20 14:32
• Updated: Yesterday 10:25
• Resolved: 18/Jan/21 08:33

Description

We fail starting any preview repair if any sstable is marked pending but the session not being finalized. The current check does not care if the range we are previewing intersects with the sstable marked pending - this means that we abort too many preview repairs.