[CASSANDRA-16249] ByteBufferAccessor.getUnsignedShort ignores ByteBuffer position

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta4, 4.0
• Component/s: Legacy/Core
• Bug Category: Correctness - Unrecoverable Corruption / Loss
• Severity: Critical
• Complexity: Low Hanging Fruit
• Discovered By: Code Inspection
• Platform: All
• Since Version: 4.0-beta1

Source Control Link

https://github.com/apache/cassandra/commit/1102687d06ab2dda3c022e4b464286a1b372e6d9

Test and Documentation Plan

Add new unit tests and modify the tests to find issues with methods assuming a zero position for the ByteBuffers.

• Assignee: Jacek Lewandowski
• Reporter: Jacek Lewandowski

Authors

Jacek Lewandowski

Reviewers

Benjamin Lerer, Berenguer Blasi

• Created: 06/Nov/20 12:04
• Updated: 03/Jan/21 16:58
• Resolved: 15/Dec/20 13:53

Description

ByteBufferAccessor.readUnsignedShort does not include the current buffer position when calculating the final offset for reading data