[CASSANDRA-16224] InvalidQueryException: Order by on unknown column From cassandra-diff

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: cassandra-diff-0.2
• Component/s: Tool/diff
• Labels: pull-request-available
• Bug Category: Availability - Process Crash
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: Adhoc Test
• Platform: All
• Since Version: cassandra-diff-0.2

Source Control Link

https://github.com/apache/cassandra-diff/commit/c3ce22c97542eaa3b0a450168bc63ce24b4ffeaa

Test and Documentation Plan

Manual container test

• Assignee: Jyothsna Konisa
• Reporter: Yifan Cai

Authors

Jyothsna Konisa

Reviewers

Marcus Eriksson, Yifan Cai

• Created: 23/Oct/20 03:49
• Updated: 06/May/21 21:37
• Resolved: 02/Feb/21 19:16

Description

Diff job fails with the following error,

  Caused by: shaded.com.datastax.driver.core.exceptions.InvalidQueryException: Order by on unknown column <column_name>
  at shaded.com.datastax.driver.core.exceptions.InvalidQueryException.copy(InvalidQueryException.java:49)
  at shaded.com.datastax.driver.core.DriverThrowables.propagateCause(DriverThrowables.java:35)
  at shaded.com.datastax.driver.core.AbstractSession.prepare(AbstractSession.java:97)
  at mme.cassandraclient.SessionWrapper.prepare(SessionWrapper.java:215)
  at org.apache.cassandra.diff.DiffCluster.getFullStatement(DiffCluster.java:272)
  at org.apache.cassandra.diff.DiffCluster.getStatementForTable(DiffCluster.java:204)
  at org.apache.cassandra.diff.DiffCluster.keyReader(DiffCluster.java:188)
  at org.apache.cassandra.diff.DiffCluster.fetchPartitionKeys(DiffCluster.java:125)
  at org.apache.cassandra.diff.DiffCluster.lambda$getPartitionKeys$0(DiffCluster.java:114)
  at org.apache.cassandra.diff.RetryStrategy.retry(RetryStrategy.java:21)
  at org.apache.cassandra.diff.DiffCluster.getPartitionKeys(DiffCluster.java:113)

The cause is that when building the select query, the ordered-by column names are not quoted. The server only sees the field names in lowercase, and it is unable to recognize.

A simple unit test to prove that the field name needs to be quoted in the query builder in order to have the built query preserve the quotes.

query = "SELECT * FROM t WHERE a='foo' ORDER BY \"bCol\" DESC;";
select = select().from("t").where(eq("a", "foo")).orderBy(desc("\"bCol\""));
assertEquals(select.toString(), query);

Issue Links

• relates to: CASSANDRA-15537 4.0 quality testing: Local Read/Write Path: Upgrade and Diff Test
• links to: GitHub Pull Request #14