[CASSANDRA-16209] Log Warning Rather than Verbose Trace when Preview Repair Validation Conflicts with Incremental Repair

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta3, 4.0
• Component/s: Local/Compaction
• Change Category: Operability
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/8818f3442e4f1321bacb7150fe5ef6fd63f2a2d0

Test and Documentation Plan

A test has been created that hits the codepath that produces this log message (and verifies that the preview and incremental repairs that interleaved behave as we expect).

• Assignee: Caleb Rackliffe
• Reporter: Caleb Rackliffe

Authors

Caleb Rackliffe

Reviewers

David Capwell, Marcus Eriksson

• Created: 13/Oct/20 17:17
• Updated: 16/Mar/22 14:29
• Resolved: 20/Oct/20 23:04

Description

When a preview repair on repaired data identifies which SSTables to validate, it might come across an SSTable that's still pending for an in-progress incremental repair session. It makes sense that we immediately fail the preview repair in that case, but the resulting error and verbose stack trace in the logs is a bit too severe a reaction. We should downgrade this to a simple warning message.