[CASSANDRA-16207] NPE when calling broadcast address on unintialized node

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.23, 3.11.9, 4.0-beta3, 4.0
• Component/s: Test/dtest/java
• Bug Category: Availability - Unavailable
• Severity: Critical
• Complexity: Low Hanging Fruit
• Discovered By: Unit Test
• Platform: All
• Since Version: 3.0.21

Source Control Link

https://github.com/apache/cassandra/commit/6eeca9d6cc482417fd4564302baa349ed76fd7ec

Test and Documentation Plan

Test included

• Assignee: Alex Petrov
• Reporter: Alex Petrov

Authors

Alex Petrov

Reviewers

David Capwell

• Created: 12/Oct/20 13:48
• Updated: 03/Jan/21 17:02
• Resolved: 14/Oct/20 08:41

Description

When trying to run upgrades, sometimes we’re calling broadcasts addrerss on an uninitialised new node:

java.lang.IllegalStateException: Can't use shut down instances, delegate is null
	at org.apache.cassandra.distributed.impl.AbstractCluster$Wrapper.delegate(AbstractCluster.java:163)
	at org.apache.cassandra.distributed.impl.DelegatingInvokableInstance.broadcastAddress(DelegatingInvokableInstance.java:53) 
	at org.apache.cassandra.distributed.impl.Instance$2.allowIncomingMessage(Instance.java:278) 
	at org.apache.cassandra.net.MessagingService.receive(MessagingService.java:1031) ~[dtest-3.0.19.jar:?]
	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:213) 
	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessages(IncomingTcpConnection.java:182) 
	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:93) 

Issue Links

• blocks: CASSANDRA-15935 Improve machinery for testing consistency in presence of range movements
• is blocked by: CASSANDRA-16157 RTE during re-serialization for message filtering during 3.0 -> 4.0 upgrade