[CASSANDRA-16151] Package tools/bin scripts as executable

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 2.2.19, 3.0.23, 3.11.9, 4.0-beta3, 4.0
• Component/s: Packaging
• Labels: patch
• Bug Category: Packaging - Source Distribution
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: User Report
• Platform: All
• Since Version: 0.7 beta 3

Source Control Link

https://github.com/apache/cassandra/commit/72941b9ec14e64af9e64365027d542b4fff41d81

Test and Documentation Plan

No documentation needed.

• Assignee: Angelo Polo
• Reporter: Angelo Polo

Authors

Angelo Polo

Reviewers

Andres de la Peña

• Created: 30/Sep/20 09:05
• Updated: 03/Jan/21 17:04
• Resolved: 21/Oct/20 12:40

Description

The tools/bin scripts aren't packaged as executable in the source distributions, though in the repository the scripts have the right bits.

This causes, on 3.11.8 for example, the tests in org.apache.cassandra.cql3.EmptyValuesTest to fail:
java.io.IOException: Cannot run program "tools/bin/sstabledump": error=13, Permission denied

[junit-timeout] junit.framework.AssertionFailedError: java.io.IOException
[junit-timeout]         at org.apache.cassandra.cql3.EmptyValuesTest.verify(EmptyValuesTest.java:85)
[junit-timeout]         at org.apache.cassandra.cql3.EmptyValuesTest.verifyJsonInsert(EmptyValuesTest.java:112)

See attached patch of build.xml for the trunk and cassandra-3.11 branches.

Issue Links

• relates to: CASSANDRA-15586 4.0 quality testing: Cluster Setup and Maintenance