[CASSANDRA-16113] Consolidate dead nodes check in force repair

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta3, 4.0
• Component/s: Local/Other
• Change Category: Code Clarity
• Complexity: Normal
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/1728da30e4e7858d30178ef74350af3e690adf0c

Test and Documentation Plan

unit test, jvm dtest

• Assignee: Yifan Cai
• Reporter: Yifan Cai

Authors

Yifan Cai

Reviewers

Blake Eggleston, Caleb Rackliffe

• Created: 08/Sep/20 19:32
• Updated: 21/Dec/20 09:29
• Resolved: 09/Oct/20 20:52

Description

The check for dead nodes during force repair is duplicated in the normal and incremental repair. We could consolidate those 2 checks to make the code more dry.
The check should throw a more meaningful error message to indicate that all neighbor nodes are down, instead of "java.lang.IllegalArgumentException: Endpoints can not be empty"