[CASSANDRA-15976] Incorrect parsing of the timestamp with less than 3 digits in the milliseconds

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta2, 4.0
• Component/s: CQL/Interpreter
• Bug Category: Correctness - API / Semantic Implementation
• Severity: Normal
• Complexity: Normal
• Discovered By: User Report
• Platform: All
• Impacts: Docs
• Since Version: 2.2.0

Source Control Link

https://github.com/apache/cassandra/commit/517d3ecceee737dffa46c47c351a43092fd4a7ba

Test and Documentation Plan

Unit tests were expanded and made more rigorous.

 

Doc: may need to visit CQL timestamp discussion and see if there is any mention of this limitation.

• Assignee: Adam Holmberg Assign to me
• Reporter: Alex Ott

Authors

Adam Holmberg

Reviewers

Brandon Williams

• Created: 24/Jul/20 06:26
• Updated: 23/Mar/22 14:33
• Resolved: 13/Aug/20 21:20

Description

(tested on 4.0-beta1, but should be in all versions)

Right now, Cassandra incorrectly handles timestamps with less than 3 digits in the milliseconds part. Timestamps (valid from the Java point of view (see below output in Scala) are either rejected (if we have 1 digit only), or incorrectly parsed when 2 digits are specified:

cqlsh> create table test.tm (id int primary key, tm timestamp);
cqlsh> insert into test.tm(id, tm) values (2, '2020-07-24T10:00:01.2Z');
InvalidRequest: Error from server: code=2200 [Invalid query] message="Unable to coerce '2020-07-24T10:00:01.2Z' to a formatted date (long)"
cqlsh> insert into test.tm(id, tm) values (1, '2020-07-24T10:00:01.12Z');
cqlsh> select * from test.tm;

 id | tm
----+---------------------------------
  1 | 2020-07-24 10:00:01.012000+0000

(1 rows)

Checking with Instant:

scala> java.time.Instant.parse("2020-07-24T10:00:01.12Z")
res0: java.time.Instant = 2020-07-24T10:00:01.120Z
scala> java.time.Instant.parse("2020-07-24T10:00:01.2Z")
res1: java.time.Instant = 2020-07-24T10:00:01.200Z

Imho it should be fixed (Cc: Adam Holmberg)

Issue Links

• breaks: CASSANDRA-17467 Timestamp issue with Cassandra 4.0.3 with Timezone value
• Dependent: CASSANDRA-14853 Change default timestamp format to output only milliseconds, not microseconds