[CASSANDRA-15973] Upgrade of custom 3.0 version fails with custom 4.0 caused by version parsing logic

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta2, 4.0
• Component/s: Build
• Bug Category: Code - Bug - Unclear Impact
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: Workload Replay
• Platform: All
• Since Version: 4.0-alpha1

Source Control Link

https://github.com/apache/cassandra/commit/57a2a8613d2595b8650c24ef1cf3bb0055202409

Test and Documentation Plan

unit tests + manual test upgrade

• Assignee: David Capwell
• Reporter: David Capwell

Authors

David Capwell

Reviewers

Brandon Williams, Jon Meredith

• Created: 23/Jul/20 17:12
• Updated: 03/Jan/21 17:02
• Resolved: 23/Jul/20 21:24

Description

In 3.0 and earlier, custom versions could have an extra digit and could have multiple pre release tags separated by -, after upgrading to 4.0 these custom versions no longer are allowed and fail different parts of the code, any place which now uses CassandraVersion.

The issue is that version was just a String before, so the only parsing rules were controlled by the client, now CassandraVersion is used which is more restrictive.

To help out, we should allow a "hot fix" digit, and preRelease should allow multiple -

Issue Links

• links to: Circle CI: Trunk
• links to: GitHub Branch: Trunk