[CASSANDRA-15820] tools/bin/fqltool doesn't work on all distributions

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta1, 4.0
• Component/s: Tool/fql
• Bug Category: Code - Bug - Unclear Impact
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: Adhoc Test
• Platform: All
• Since Version: 4.0-alpha

Source Control Link

https://github.com/apache/cassandra/commit/ec07cd7e76c93bf713618f381480f500f6c4e62f

Test and Documentation Plan

Local dtest run

• Assignee: Robert Stupp
• Reporter: Robert Stupp

Authors

Robert Stupp

Reviewers

Michael Semb Wever

• Created: 19/May/20 04:59
• Updated: 21/Dec/20 08:07
• Resolved: 19/May/20 14:37

Description

The line

if [ ! $1 ]; then break; fi

doesn't work on all OSes/Linux distributions (e.g. a bare Ubuntu 18.04) with #!/bin/sh causing fqltool to fail. The fix is quite simple