[CASSANDRA-15819] nodetool enablefullquerylog doesn't allow caller to make non-blocking

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta1, 4.0
• Component/s: Tool/nodetool
• Bug Category: Correctness - API / Semantic Implementation
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: User Report
• Platform: All
• Since Version: 4.0-alpha

Source Control Link

https://github.com/apache/cassandra/commit/94c52450ed9ad3fd704faef7d395ede5050fcdc3

Test and Documentation Plan

See PR

• Assignee: Berenguer Blasi
• Reporter: David Capwell

Authors

Berenguer Blasi

Reviewers

Benjamin Lerer, David Capwell

• Created: 19/May/20 00:52
• Updated: 21/Dec/20 08:08
• Resolved: 20/May/20 11:57

Description

$ ./bin/nodetool enablefullquerylog --path /tmp/deleteme --blocking false
Picked up _JAVA_OPTIONS: -Djava.net.preferIPv4Stack=true
nodetool: Found unexpected parameters: [false]
See 'nodetool help' or 'nodetool help <command>'.

The root cause is boolean is special cased in airlift, so any time —blocking is set it gets turned on.

Issue Links

• is related to: CASSANDRA-13983 Support a means of logging all queries as they were invoked
• links to: CASSANDRA-15819 PR 4.0