[CASSANDRA-15781] Fix flakiness of DecayingEstimatedHistogramReservoirTest#testStriping and apply the same "fix" to other tests

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta1, 4.0
• Component/s: Test/unit
• Change Category: Quality Assurance
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/df8e736700ae2a06675ff50381788d708bc22b96

Test and Documentation Plan

-

• Assignee: Robert Stupp
• Reporter: Robert Stupp

Authors

Robert Stupp

Reviewers

Eduard Tudenhoefner, Robert Stupp

• Created: 04/May/20 08:25
• Updated: 15/May/20 08:48
• Resolved: 04/May/20 15:01

Description

The unit test DecayingEstimatedHistogramReservoirTest#testStriping is flaky, especially when many tests are running concurrently, because the used thread-pool can still be running when the assertions are tested (i.e. the ExecutorService.awaitTermination() returned false).

The "fix" is rather a band aid: extend the wait-period to 1 minute, check the return value of awaitTermination and apply the same change to some other tests that might be affected as well.