[CASSANDRA-15736] Fix Python SyntaxWarning: "is not" with a literal. Did you mean "!="

• Type: Task
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta1, 4.0
• Component/s: Test/dtest/python
• Labels: pull-request-available
• Change Category: Quality Assurance
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://github.com/apache/cassandra-dtest/commit/9ec133b2f728ef0dd9d5995af61a0ef61dc47525

Test and Documentation Plan

See syntaxwarnings

• Assignee: Eduard Tudenhoefner
• Reporter: Eduard Tudenhoefner

Authors

Eduard Tudenhoefner

Reviewers

Michael Semb Wever

• Created: 16/Apr/20 07:43
• Updated: 15/May/20 08:55
• Resolved: 17/Apr/20 09:02

Description

With the upgrade to Python 3.8 there are SyntaxWarnings now showing up in the tests, which should be fixed.

/home/cassandra/cassandra/cassandra-dtest/conftest.py:207: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if len(errors) is not 0:
/home/cassandra/cassandra/cassandra-dtest/conftest.py:240: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if len(logs) is not 0:
/home/cassandra/cassandra/venv/src/ccm/ccmlib/repository.py:393: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  while attempt < 3 and ret_val is not 0:
/home/cassandra/cassandra/venv/src/ccm/ccmlib/repository.py:399: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if ret_val is not 0:
/home/cassandra/cassandra/venv/src/ccm/ccmlib/repository.py:422: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if ret_val is not 0:
/home/cassandra/cassandra/venv/src/ccm/ccmlib/repository.py:425: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if ret_val is not 0:
/home/cassandra/cassandra/cassandra-dtest/dtest_setup.py:124: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if len(filtered_errors) is not 0:
/home/cassandra/cassandra/cassandra-dtest/dtest_setup.py:152: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if len(logs) is not 0:
/home/cassandra/cassandra/cassandra-dtest/dtest_setup.py:286: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if len(errors) is not 0:

Issue Links

• links to: CCM PR
• links to: GitHub Pull Request #65