[CASSANDRA-15728] Setting "cassandra_dir" in pytest.ini has no effect

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta1, 4.0
• Component/s: Test/dtest/python
• Labels: pull-request-available
• Bug Category: Correctness
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: User Report
• Platform: All
• Since Version: 4.0-alpha

Source Control Link

https://github.com/apache/cassandra-dtest/commit/158f084779159e8341c080a90d759a89006f5829

Test and Documentation Plan

run pytest sometest.py with cassandra_dir being set in pytest.ini

• Assignee: Eduard Tudenhoefner
• Reporter: Eduard Tudenhoefner

Authors

Eduard Tudenhoefner

Reviewers

Benjamin Lerer, Berenguer Blasi

• Created: 15/Apr/20 07:14
• Updated: 21/Dec/20 08:08
• Resolved: 16/Apr/20 15:37

Description

Setting cassandra_dir in pytest.ini should not require specifying --cassandra-dir on the command line:

$ pytest cql_tracing_test.py
============================================================================================================ test session starts =============================================================================================================
platform linux -- Python 3.6.9, pytest-3.6.4, py-1.8.1, pluggy-0.7.1
rootdir: /home/nastra/Development/pycharm-projects/cassandra-dtest, inifile: pytest.ini
plugins: timeout-1.3.4, flaky-3.6.1
timeout: 900.0s
timeout method: signal
timeout func_only: False
collecting 4 items                                                                                                                                                                                                                           
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/home/nastra/dtest/lib/python3.6/site-packages/_pytest/main.py", line 178, in wrap_session
INTERNALERROR>     session.exitstatus = doit(config, session) or 0
INTERNALERROR>   File "/home/nastra/dtest/lib/python3.6/site-packages/_pytest/main.py", line 214, in _main
INTERNALERROR>     config.hook.pytest_collection(session=session)
INTERNALERROR>   File "/home/nastra/dtest/lib/python3.6/site-packages/pluggy/hooks.py", line 258, in __call__
INTERNALERROR>     return self._hookexec(self, self._nonwrappers + self._wrappers, kwargs)
INTERNALERROR>   File "/home/nastra/dtest/lib/python3.6/site-packages/pluggy/manager.py", line 67, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook, methods, kwargs)
INTERNALERROR>   File "/home/nastra/dtest/lib/python3.6/site-packages/pluggy/manager.py", line 61, in <lambda>
INTERNALERROR>     firstresult=hook.spec_opts.get('firstresult'),
INTERNALERROR>   File "/home/nastra/dtest/lib/python3.6/site-packages/pluggy/callers.py", line 201, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>   File "/home/nastra/dtest/lib/python3.6/site-packages/pluggy/callers.py", line 76, in get_result
INTERNALERROR>     raise ex[1].with_traceback(ex[2])
INTERNALERROR>   File "/home/nastra/dtest/lib/python3.6/site-packages/pluggy/callers.py", line 180, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>   File "/home/nastra/dtest/lib/python3.6/site-packages/_pytest/main.py", line 224, in pytest_collection
INTERNALERROR>     return session.perform_collect()
INTERNALERROR>   File "/home/nastra/dtest/lib/python3.6/site-packages/_pytest/main.py", line 429, in perform_collect
INTERNALERROR>     session=self, config=self.config, items=items
INTERNALERROR>   File "/home/nastra/dtest/lib/python3.6/site-packages/pluggy/hooks.py", line 258, in __call__
INTERNALERROR>     return self._hookexec(self, self._nonwrappers + self._wrappers, kwargs)
INTERNALERROR>   File "/home/nastra/dtest/lib/python3.6/site-packages/pluggy/manager.py", line 67, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook, methods, kwargs)
INTERNALERROR>   File "/home/nastra/dtest/lib/python3.6/site-packages/pluggy/manager.py", line 61, in <lambda>
INTERNALERROR>     firstresult=hook.spec_opts.get('firstresult'),
INTERNALERROR>   File "/home/nastra/dtest/lib/python3.6/site-packages/pluggy/callers.py", line 201, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>   File "/home/nastra/dtest/lib/python3.6/site-packages/pluggy/callers.py", line 76, in get_result
INTERNALERROR>     raise ex[1].with_traceback(ex[2])
INTERNALERROR>   File "/home/nastra/dtest/lib/python3.6/site-packages/pluggy/callers.py", line 180, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>   File "/home/nastra/Development/pycharm-projects/cassandra-dtest/conftest.py", line 440, in pytest_collection_modifyitems
INTERNALERROR>     raise Exception("Required dtest arguments were missing! You must provide either --cassandra-dir "
INTERNALERROR> Exception: Required dtest arguments were missing! You must provide either --cassandra-dir or --cassandra-version. Refer to the documentation or invoke the help with --help.

Issue Links

• links to: GitHub Pull Request #64