Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-15694

Statistics upon streaming of entire SSTables in Netstats is wrong

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Fix Version/s: 4.0-beta1, 4.0
    • Component/s: Tool/nodetool
    • Labels:
      None

      Description

      There is a bug in the current code (trunk on 6th April 2020) as if we are streaming entire SSTables via CassandraEntireSSTableStreamWriter and CassandraOutgoingFile respectively, there is not any update on particular components of a SSTable as it counts only "db" file to be there. That introduces this bug:

       

      Mode: NORMAL
      Rebuild 2c0b43f0-735d-11ea-9346-fb0ffe238736
          /127.0.0.2 Sending 19 files, 27664559 bytes total. Already sent 133 files, 27664559 bytes total
              /tmp/dtests15682026295742741219/node2/data/distributed_test_keyspace/cf-196b3...
              ....
      

      Basically, number of files to be sent is lower than files sent.

       

      The straightforward fix here is to distinguish when we are streaming entire sstables and in that case include all manifest files into computation. 

       

      This issue depends on CASSANDRA-15657 because the resolution whether we stream entirely or not is got from a method which is performance sensitive and computed every time. Once CASSANDRA-15657  (hence CASSANDRA-14586) is done, this ticket can be worked on.

       

      branch with fix is here: https://github.com/smiklosovic/cassandra/tree/CASSANDRA-15694

        Attachments

        Issue Links

          Activity

            People

            • Assignee:
              stefan.miklosovic Stefan Miklosovic Assign to me
              Reporter:
              stefan.miklosovic Stefan Miklosovic
              Authors:
              Stefan Miklosovic
              Reviewers:
              Dinesh Joshi

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 20m
                20m

                  Issue deployment