[CASSANDRA-15690] Single partition queries can mistakenly omit partition deletions and resurrect data

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.21, 3.11.7, 4.0-beta1, 4.0
• Component/s: Consistency/Coordination
• Bug Category: Correctness - Transient Incorrect Response
• Severity: Critical
• Complexity: Normal
• Discovered By: Code Inspection
• Platform: All
• Since Version: 3.0 alpha 1

Source Control Link

https://github.com/apache/cassandra/commit/092915ad19d25c1ba93f7968210b88fb6e4b9180

Test and Documentation Plan

New in-jvm dtests added. For trunk, the proposed snapshot on mismatch feature has a descriptive comment in cassandra.yaml, but we should add full docs for repaired data tracking in general.

• Assignee: Sam Tunnicliffe
• Reporter: Aleksey Yeschenko

Authors

Sam Tunnicliffe

Reviewers

Aleksey Yeschenko

• Created: 03/Apr/20 17:57
• Updated: 21/Oct/20 12:25
• Resolved: 16/Apr/20 17:48

Description

We have logic that allows us to exclude sstables with partition deletions that are older than the minimum collected timestamp in a local request. However, it’s possible that another node could have rows that aren’t known to the local node that are in turn older than the excluded partition deletion. In such a scenario, those will be mistakenly resurrected, which is a correctness issue.