[CASSANDRA-15684] CASSANDRA-15650 was merged after dtest refactor and modified classes no longer in the project

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0, 4.0-alpha4
• Component/s: Test/dtest/java
• Labels: pull-request-available
• Bug Category: Code - Bug - Unclear Impact
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: Unit Test
• Platform: All
• Since Version: 4.0-alpha

Source Control Link

https://github.com/apache/cassandra/commit/a104b06d4aea2f2cd3d48bdbe38410284f236428

Test and Documentation Plan

circle ci

• Assignee: David Capwell
• Reporter: David Capwell

Authors

David Capwell

Reviewers

Alex Petrov, Benjamin Lerer, David Capwell

• Created: 02/Apr/20 17:54
• Updated: 27/Aug/20 15:03
• Resolved: 06/Apr/20 17:09

Description

CASSANDRA-15650 was based off commits before CASSANDRA-15539 which removed some of the files modified in CASSANDRA-15650. The tests were passing pre-merge but off earlier commits. On commit they started failing since the dtest API no longer match so produces the following exception

[junit-timeout] org.apache.cassandra.distributed.api.NodeToolResult$Asserts.errorContains([Ljava/lang/String;)Lorg/apache/cassandra/distributed/api/NodeToolResult$Asserts;
[junit-timeout] java.lang.NoSuchMethodError: org.apache.cassandra.distributed.api.NodeToolResult$Asserts.errorContains([Ljava/lang/String;)Lorg/apache/cassandra/distributed/api/NodeToolResult$Asserts;
[junit-timeout]         at org.apache.cassandra.distributed.test.RepairCoordinatorFast.lambda$unknownHost$5(RepairCoordinatorFast.java:216)
[junit-timeout]         at org.apache.cassandra.utils.AssertUtil.lambda$assertTimeoutPreemptively$0(AssertUtil.java:39)
[junit-timeout]         at org.apache.cassandra.utils.AssertUtil.lambda$assertTimeoutPreemptively$1(AssertUtil.java:67)
[junit-timeout]         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[junit-timeout]         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[junit-timeout]         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[junit-timeout]         at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
[junit-timeout]         at java.lang.Thread.run(Thread.java:748)

Root cause was 4 files exited which should have been deleted in CASSANDRA-15539. Since they were not when CASSANDRA-15650 modified one it didn't cause a merge conflict, but when the test runs it conflicts and fails.

Circle CI

Issue Links

• is duplicated by: CASSANDRA-15695 Fix NoSuchMethodError: 'org.apache.cassandra.distributed.api.NodeToolResult$Asserts
• is related to: CASSANDRA-15650 Fix flaky test org.apache.cassandra.distributed.test.*RepairCoordinatorFastTest
• links to: GitHub Pull Request #5
• links to: GitHub Pull Request #511