[CASSANDRA-15674] liveDiskSpaceUsed and totalDiskSpaceUsed get corrupted if IndexSummaryRedistribution gets interrupted

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta1, 4.0
• Component/s: Local/Compaction, Observability/Metrics
• Bug Category: Correctness - Recoverable Corruption / Loss
• Severity: Normal
• Complexity: Normal
• Discovered By: User Report
• Platform: All
• Since Version: 3.0.0

Source Control Link

https://github.com/apache/cassandra/commit/b105e919678240b5f448df9acaf6c93117f0c0cc

Test and Documentation Plan

PR: https://github.com/apache/cassandra/pull/500

• Assignee: David Capwell
• Reporter: David Capwell

Authors

David Capwell

Reviewers

Jordan West, Marcus Eriksson

• Created: 27/Mar/20 23:50
• Updated: 15/May/20 08:54
• Resolved: 07/May/20 10:28

Description

IndexSummaryRedistribution is a compaction task and as such extends Holder and supports cancelation by throwing a CompactionInterruptedException. The issue is that IndexSummaryRedistribution tries to use transactions, but mutates the sstable in-place; transaction is unable to roll back.

This would be fine (only updates summary) if it wasn’t for the fact the task attempts to also mutate the two metrics liveDiskSpaceUsed and totalDiskSpaceUsed, since these can’t be rolled back any cancelation could corrupt these metrics.

Issue Links

• links to: Github PR