[CASSANDRA-15597] Correct Visibility and Improve Safety of Methods in LatencyMetrics

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta1, 4.0
• Component/s: Observability/Metrics
• Change Category: Code Clarity
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/c5eb532b63e80bb976d9dfdd4aa1c76f27f726e5

Test and Documentation Plan

existing test suite

• Assignee: Jeff
• Reporter: Jordan West

Authors

Jeff

Reviewers

Jordan West

• Created: 25/Feb/20 01:43
• Updated: 15/May/20 08:53
• Resolved: 16/Apr/20 00:02

Description

• add/removeChildren does not need to be public (and exposing addChildren is unsafe since no lock is used).
• casting in the constructor is safer than casting each time in removeChildren